feat: Support ERC-6492 signature verification on zksync chains #5440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
joaquim-verges
changed the title
joaquim-verges
force-pushed
the
11-16-support_erc-6492_signature_verification_on_zksync_chains
branch
from
fdafa5e to
60a8d18
Compare
🦋 Changeset detectedLatest commit: d6fde76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5440 +/- ##
==========================================
- Coverage 45.53% 45.52% -0.01%
==========================================
Files 1070 1070
Lines 55690 55707 +17
Branches 4033 4031 -2
==========================================
+ Hits 25356 25360 +4
- Misses 29647 29660 +13
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
force-pushed
the
11-16-support_erc-6492_signature_verification_on_zksync_chains
branch
from
60a8d18 to
d6fde76
Compare
joaquim-verges
deleted the
11-16-support_erc-6492_signature_verification_on_zksync_chains
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Fixes CNCT-2383
PR-Codex overview
This PR focuses on enhancing signature verification for ERC-6492 on the zksync blockchain, improving error handling, and adjusting the verification logic to accommodate zksync-specific requirements.
Detailed summary
verify-signature.tsandverify-hash.ts.ZKSYNC_VALIDATOR_ADDRESSconstant.verificationDatalogic to handle zksync chains.verifyHashto usehexToBool.